Merged
Conversation
Owner
Author
|
@XhmikosR I'd appreciate if you could take a look and approve this PR :) |
feimosi
force-pushed
the
feature/95-alt-attribute
branch
from
5b56626 to
d7b6fd4
Compare
| var image = create('img'); | ||
| var figcaption = create('figcaption'); | ||
|
|
||
| // Prepare figure and figcaption elements |
Contributor
There was a problem hiding this comment.
"and figcaption elements" belongs to line 504 now I believe.
Owner
Author
There was a problem hiding this comment.
Right, I've removed this unnecessary keyword
feimosi
force-pushed
the
feature/95-alt-attribute
branch
from
d7b6fd4 to
c244460
Compare
Contributor
|
Looks good to me sans the refactoring patch which I assume you tested :) |
Owner
Author
|
I wouldn't publish untested code :) Just wanted to make sure, we were thinking about the |
Contributor
|
I know, better be safe than sorry :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #96