PR 139 + 140 and an Ignore Class#141
Closed
davidhellmann wants to merge 2 commits intofeimosi:devfrom
davidhellmann:patch-3
Closed
PR 139 + 140 and an Ignore Class#141davidhellmann wants to merge 2 commits intofeimosi:devfrom davidhellmann:patch-3
davidhellmann wants to merge 2 commits intofeimosi:devfrom
davidhellmann:patch-3
Conversation
I've a Gallery where is the link that trigger the baguetteBox but I've also a link that triggers an Image Download.
I've added a option `ignoreClass: 'baguetteBox-disabled'` and update this line:
`tagsNodeList = galleryElement.getElementsByTagName('a');`
to:
`tagsNodeList = galleryElement.querySelectorAll('a:not(.'+ options.ignoreClass +')');`
Maybe also Interesting :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've a Gallery where is the link that trigger the baguetteBox but I've also a link that triggers an Image Download.
I've added a option
ignoreClass: 'baguetteBox-disabled'and update this line:tagsNodeList = galleryElement.getElementsByTagName('a');to:
tagsNodeList = galleryElement.querySelectorAll('a:not(.'+ options.ignoreClass +')');Maybe also Interesting :)