Add Body Class and Ignore Class#143
Conversation
|
No problem, thanks! There are a few linter errors, could you take a look? |
|
@feimosi: just fix them yourself and push to @davidhellmann fork and then just squash + merge. |
|
I can't push to other's forks without some extra permission, can I? |
|
Yep you can. This is the default option for PRs opened like in the last
year. See the command line instructions in a PR in a project of yours :)
…On Sep 15, 2017 20:23, "Marek Grzybek" ***@***.***> wrote:
I can't push to other's forks without some extra permission, can I?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#143 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVVtUw-Cnf1fTWwrMgIJ5yoveMHuDQdks5sirKZgaJpZM4LtNkG>
.
|
|
@XhmikosR Interesting, thanks! :) |
|
@feimosi: I replied via email but you probably missed it.
|
|
@XhmikosR I didn't get that message. I'll test test thoroughly before the next release too. |
|
@feimosi: I wouldn't personally go with that. If you still want to support < IE 9 you should do this https://plainjs.com/javascript/attributes/adding-removing-and-testing-for-classes-9/ |
|
Sure, it works only in newer IE, but using this option won't break anything, so I don't see any hazard here. Treat it as progressive enhancement, I just need to mention that in the docs. |
3 participants
Hey, here is a new Pull Request. Now you can see it better I hope :)
Sorry for the late response!