(feat) Add home/end key support#179
Merged
feimosi merged 1 commit intofeimosi:devfrom Sep 16, 2018
BartDelrue:feature/home-end-key
Merged
(feat) Add home/end key support#179feimosi merged 1 commit intofeimosi:devfrom BartDelrue:feature/home-end-key
feimosi merged 1 commit intofeimosi:devfrom
BartDelrue:feature/home-end-key
Conversation
Closed
meirege
approved these changes
Jul 6, 2018
|
We could really use this for an upcoming project at our firm. 👍 |
feimosi
reviewed
Jul 6, 2018
|
|
||
| // Return false at the left end of the gallery | ||
| function showFirstImage(event) { | ||
| if (event) { |
Owner
There was a problem hiding this comment.
Do we need the if? Is there a case where event is undefined?
Contributor
Author
There was a problem hiding this comment.
Currently no.
I included it in case you'd want to expose this function later on, cfr shownext etc.
Contributor
Author
There was a problem hiding this comment.
Let me know if you want it gone ;)
There was a problem hiding this comment.
Could this be merged please? We could really use this feature...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pressing the home or end key takes you to the first or last image of the opened gallery.
Issue #180