(feat) Add mousewheel support#244
Open
derdritte wants to merge 1 commit intofeimosi:devfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To let mouse-wheel events change the current picture to the previous or next picture:
Default is false, that seemed appropriate to me.
The current implementation prevents default and, to avoid having to restructure when (user)options are loaded, the event-handler is always added to the overlay and the event-handler will check the option on each event. Naturally this is not ideal, but didn't think adding this small feature warranted that level of refactoring. I am not a JS-dev, any input is appreciated.
An (additional) option to allow inverting of the directions the scroll-events get translated to can be added easily, if desired.
I also read the contribution guidelines, but opening a ticket for such a minimal change seemed overkill, if the feature isn't welcome or relevant, the PR can be closed. If you want the discussion anyway, I'd be happy to open an issue.