Mustache specs - method interpolation compliance#305
Open
danielfagerstrom wants to merge 5 commits intojanl:masterfrom
Open
Mustache specs - method interpolation compliance#305danielfagerstrom wants to merge 5 commits intojanl:masterfrom
danielfagerstrom wants to merge 5 commits intojanl:masterfrom
Conversation
…bda should be interpolated. This breaks one of the current tests of lambdas (higher order sections), as it asumes that the result is not interpolated. I updated the test so that it pass.
…d calls. All metods in a name path should be called in the context of their containing object. In current mustache.js only the last name in a path is called and it is called in the context of the name lookup rather than of its object. This patch breaks the current behaviour, so I provided an extra context parameter to make it easier to update programs using the current function context behaviour. A breaking test is fixed and there are new tests for method calls etc.
Updated documentation for the new method interpolation behavior.
Contributor
|
@danielfagerstrom I've merged in the first few commits in this pull request. Would you please remove them from this request and limit the scope of this pull request to only the commits that have to do with method interpolation compliance? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the Mustache spec if the name parts in a doted name refers to methods, these methods should be called in the context of the object they are contained in. In mustache.js only the last name in a doted name is called (if it is a function) and it is called in the context of the current view object rather than in the context of its object.
I try to use mustache.js on nested objects that contain accessor methods and it would be much easier if mustache.js followed the behavior from the spec. And I have therefore implemented that behavior.
If we e.g. have a interpolation
{{foo.bar}}wherefoois a method in the current view that returns a objectowith abarmethod,foowill be called in the context of the current view andbarwill be called in the context ofo.Unfortunately this change break some current function behavior, I have updated one of the tests and the documentation to reflect this. And provided tests for the new behavior.