Fix/bom test#448
Open
dasilvacontin wants to merge 3 commits intojanl:masterfrom
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR relocates the BOM test to the correct directory and updates the test template and JavaScript syntax to ensure correct unescaped output handling.
- Moved the BOM test file from spec/_files to test/_files.
- Updated the test template output to be unescaped.
- Revised the BOM render test JavaScript syntax to a more modern format.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/_files/bom_as_whitespace.js | Introduces new object literal containing BOM-related keys. |
| spec/_files/bom_as_whitespace.js | Removes the outdated test file, as its content is now in the proper directory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm also interested in seeing Travis result.